Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BED-5539): Update image flavor tag generation logic in workflow #1204

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

neumachen
Copy link
Contributor

@neumachen neumachen commented Mar 7, 2025

Description

This PR fixes the Docker image tagging in the CD workflow. The change modifies the image_flavor parameter in the GitHub Actions workflow to set the "latest" tag for Docker images correctly.

The change updates the syntax from:

image_flavor: ${{ (github.ref_name == 'main' || contains(github.ref_name, '-rc')) && 'latest=false' }}

To:

image_flavor: latest=${{ (github.ref_name == 'main' || contains(github.ref_name, '-rc')) == false }}

This ensures the "latest" tag is applied correctly based on the branch conditions.

Motivation and Context

This PR addresses BED-5539

The current implementation of Docker image tagging in the CD workflow does not correctly apply the "latest" tag. This change fixes the syntax to ensure images are correctly tagged according to the branch conditions.

How Has This Been Tested?

Veifiried manually using act by validating the cd.yml template through a workflow run.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@neumachen neumachen self-assigned this Mar 7, 2025
Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull!

@neumachen neumachen changed the title fix(bp-1419): Update image flavor tag generation logic in workflow fix(BED-5539): Update image flavor tag generation logic in workflow Mar 7, 2025
@zinic zinic changed the base branch from main to stage/v7.1.0 March 7, 2025 16:50
Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rebase this on stage/v7.1.0

Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and check looks good on my end. Pull (again)!

@zinic zinic merged commit f346d6b into stage/v7.1.0 Mar 7, 2025
6 checks passed
@zinic zinic deleted the bug/bp-1419 branch March 7, 2025 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants