-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modify dockerfile to build with stbernard #578
Conversation
41379cf
to
5edd923
Compare
…in the environment and exactly where we're failing
…dhound containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only one of these suggestions I'm really worried about is the potential panic, otherwise these are minor suggestions that can be either changed or resolved as wontfix. Overall this looks really good and I appreciate getting this plumbed in properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates, looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pull!
Description
This PR updates the existing Dockerfile to build with
stbernard
instead ofbeagle
. A few key changes were necessary to enable this functionality:GOOS
andGOARCH
environment variables. This enablesstbernard
to build against any environment viago run
. Prior to this change the variables would conflict against the architecture that was callinggo run stbernard
.Also included in this PR is the removal of Python from the Docker build as it was only used by
beagle.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: