Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify dockerfile to build with stbernard #578

Merged
merged 13 commits into from
Jun 18, 2024

Conversation

superlinkx
Copy link
Contributor

@superlinkx superlinkx commented Apr 24, 2024

Description

This PR updates the existing Dockerfile to build with stbernard instead of beagle. A few key changes were necessary to enable this functionality:

  • Pulling the version from the environment variable if the git tag was unavailable. This was necessary to support building the edge release.
  • Adding flags to override the GOOS and GOARCH environment variables. This enables stbernard to build against any environment via go run. Prior to this change the variables would conflict against the architecture that was calling go run stbernard.

Also included in this PR is the removal of Python from the Docker build as it was only used by beagle.

Motivation and Context

  • Consolidate on a single CLI tool for BloodHound

How Has This Been Tested?

  • Ran the builds locally and on GitHub actions and verified they built successfully

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@sircodemane sircodemane added the tooling This updates developer tooling label Jun 11, 2024
@juggernot325 juggernot325 force-pushed the stbernard-dockerfile branch from 41379cf to 5edd923 Compare June 14, 2024 13:48
@juggernot325 juggernot325 marked this pull request as ready for review June 17, 2024 17:29
Copy link
Contributor Author

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only one of these suggestions I'm really worried about is the potential panic, otherwise these are minor suggestions that can be either changed or resolved as wontfix. Overall this looks really good and I appreciate getting this plumbed in properly.

Copy link
Contributor Author

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates, looks good to me

Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pull!

@juggernot325 juggernot325 merged commit b082060 into main Jun 18, 2024
3 checks passed
@juggernot325 juggernot325 deleted the stbernard-dockerfile branch June 18, 2024 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tooling This updates developer tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants