Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve query complexity calculations #586

Merged
merged 6 commits into from
May 2, 2024
Merged

improve query complexity calculations #586

merged 6 commits into from
May 2, 2024

Conversation

irshadaj
Copy link
Contributor

@irshadaj irshadaj commented Apr 26, 2024

Description

  • Improved code readability by using better suited data types in query complexity calculations
  • Fixed missed loophole in query complexity calculation
  • Refactored reduction factor into its own function to aid readability
  • Added runtime measurements and logging for cypher queries to better inform the appropriateness of our reduction factor calculations in the future

How Has This Been Tested?

Changed code paths are under extensive unit and integration tests, which had to be updated accordingly.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@irshadaj irshadaj added the work in progress This pull request is a work in progress and should not be merged label Apr 26, 2024
@irshadaj irshadaj self-assigned this Apr 26, 2024
@irshadaj irshadaj changed the title changed complexity values to ints improve query complexity calculations Apr 26, 2024
@irshadaj irshadaj marked this pull request as draft April 30, 2024 19:12
@irshadaj irshadaj removed the work in progress This pull request is a work in progress and should not be merged label Apr 30, 2024
@irshadaj irshadaj force-pushed the query_complexity branch from 2b40ce5 to 05ecf39 Compare May 1, 2024 15:26
@irshadaj irshadaj force-pushed the query_complexity branch from 05ecf39 to 66e55a0 Compare May 1, 2024 18:36
@irshadaj irshadaj marked this pull request as ready for review May 1, 2024 18:39
@irshadaj irshadaj force-pushed the query_complexity branch from 07f0213 to ca9c9b2 Compare May 1, 2024 20:59
Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question on a test condition changing to better understand. Otherwise, this all looks as expected

Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding test coverage!

@irshadaj irshadaj enabled auto-merge (squash) May 2, 2024 18:00
@irshadaj irshadaj merged commit c619d15 into main May 2, 2024
3 checks passed
@irshadaj irshadaj deleted the query_complexity branch May 2, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants