Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove filters by category #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruslanrf
Copy link

No description provided.

@nathanbowser
Copy link
Member

Generally I already think the API is bloated. This makes it worse. Can you think of a way to condense all these methods?

@ruslanrf
Copy link
Author

This functionality is necessary if the filter with an array of elements has to be cleaned by a specific category (e.g. follow or location), otherwise, a user has to call corresponding functions for each item in the array in the filter. (e.g. unfollow() for each user id added with the function follow() )...
Maybe an alternative approach can be just to expose (add "this") variables such as FILTER_TYPE_TRACKING, FILTER_TYPE_LOCATION, FILTER_TYPE_FOLLOW, and FILTER_TYPE_LANGUAGE? As well as removeFilter(), removeAllFilters()?

@nathanbowser
Copy link
Member

Yea, that might be nicer. Want to give it a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants