-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pdf generation with docker #133
Conversation
09eee43
to
87d62de
Compare
Oooh check failed because of SpinalHDL/SpinalHDL#913, I will have update links in another PR after SpinalHDL/SpinalHDL#918 is merged Edit: broken link removed, rebased this PR |
Add instructions in README
Using a git version of sphinx-multiversion, needed to add git to Dockerfile
87d62de
to
aaa4266
Compare
b506088
to
6925bbb
Compare
I am editing |
I've got an error I can't fix https://github.com/numero-744/SpinalDoc-RTD/actions/runs/3472250039/jobs/5802824263 So now I try just using Docker because, well, the configuration is already here! (I try to add caching of the built docker image as well, WIP) |
It's alive! https://numero-744.github.io/SpinalDoc-RTD/ (but I might break this link soon XD) I do some fixes for caching then I update this PR. |
Okay so for now it seems I fail with caching the docker image… But maybe it is just because cache is used only for when history goes forward so I don't know. Anyway, it is not a big deal as it is only on release, not for PRs. |
Ahhh, it is not mergable now, due to the duplicated modification on README i think. |
Why we need to change the files in .github directory when the target is just generate a pdf by docker? |
@Readon the conflict is fixed now. Because the idea is to provide access to the PDF from the site like in #132 (comment) or in live demo: https://numero-744.github.io/SpinalDoc-RTD/master/ |
Ahhh, I guess you merged the two targets into one.
|
Yes, using docker was more a way to ease setting things up (can be tested locally, really useful for debug) |
Yes, docker is very good. However, I'm not familiar with this, so I can't give any more advice. :) |
Maybe we can merge this first to see if there is any feedback. |
This is from an unreleased feature of multiversion I was pointed to: #132 (comment) I'm okay with it: you have a button with versions, you find old versions and different formats. But I'm working on a big refactoring of the docs (PR not open yet), I'll take it into consideration, to make this |
Maybe another PR is better to keep the repo's history clean. |
Yea, will be a really big PR on its own, no need to mix it with other things XD |
Fix #132
I still have to add it to GitHub actions, but there is still discussion needed in #132 about this.