Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pdf generation with docker #133

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Conversation

numero-744
Copy link
Collaborator

Fix #132

I still have to add it to GitHub actions, but there is still discussion needed in #132 about this.

@numero-744 numero-744 requested a review from wifasoi October 25, 2022 11:55
@numero-744 numero-744 self-assigned this Oct 25, 2022
@numero-744 numero-744 force-pushed the pdf-gen-docker branch 2 times, most recently from 09eee43 to 87d62de Compare October 26, 2022 20:59
@numero-744
Copy link
Collaborator Author

numero-744 commented Oct 26, 2022

Oooh check failed because of SpinalHDL/SpinalHDL#913, I will have update links in another PR after SpinalHDL/SpinalHDL#918 is merged

Edit: broken link removed, rebased this PR

@numero-744
Copy link
Collaborator Author

I am editing .github/workflows/push-doc.yml and I notice the redirection. I am wondering, is it possible to push a page right on https://spinalhdl.github.io/ with a redirection?

@numero-744
Copy link
Collaborator Author

I've got an error I can't fix https://github.com/numero-744/SpinalDoc-RTD/actions/runs/3472250039/jobs/5802824263

So now I try just using Docker because, well, the configuration is already here! (I try to add caching of the built docker image as well, WIP)

@numero-744
Copy link
Collaborator Author

numero-744 commented Nov 15, 2022

It's alive! https://numero-744.github.io/SpinalDoc-RTD/ (but I might break this link soon XD)

I do some fixes for caching then I update this PR.

@numero-744
Copy link
Collaborator Author

Okay so for now it seems I fail with caching the docker image… But maybe it is just because cache is used only for when history goes forward so I don't know. Anyway, it is not a big deal as it is only on release, not for PRs.

@numero-744 numero-744 marked this pull request as ready for review November 15, 2022 18:08
@numero-744
Copy link
Collaborator Author

@wifasoi @Dolu1990 ready for review ❤️

@numero-744 numero-744 changed the title build: pdf generation with docker ci: pdf generation with docker Nov 16, 2022
@numero-744 numero-744 mentioned this pull request Nov 17, 2022
@Readon
Copy link
Collaborator

Readon commented Nov 17, 2022

Ahhh, it is not mergable now, due to the duplicated modification on README i think.

@Readon
Copy link
Collaborator

Readon commented Nov 17, 2022

Why we need to change the files in .github directory when the target is just generate a pdf by docker?

@numero-744
Copy link
Collaborator Author

@Readon the conflict is fixed now.

Because the idea is to provide access to the PDF from the site like in #132 (comment) or in live demo: https://numero-744.github.io/SpinalDoc-RTD/master/

@Readon
Copy link
Collaborator

Readon commented Nov 17, 2022

@Readon the conflict is fixed now.

Because the idea is to provide access to the PDF from the site like in #132 (comment) or in live demo: https://numero-744.github.io/SpinalDoc-RTD/master/

Ahhh, I guess you merged the two targets into one.

  1. generate pdf with docker.
  2. automatically generate & publish pdf file on corresponding website.

@numero-744
Copy link
Collaborator Author

Yes, using docker was more a way to ease setting things up (can be tested locally, really useful for debug)

@Readon
Copy link
Collaborator

Readon commented Nov 17, 2022

Yes, using docker was more a way to ease setting things up (can be tested locally, really useful for debug)

Yes, docker is very good.
Except that the link to the generated pdf is hidden too deep.

However, I'm not familiar with this, so I can't give any more advice. :)

@Readon
Copy link
Collaborator

Readon commented Nov 17, 2022

Maybe we can merge this first to see if there is any feedback.

@numero-744
Copy link
Collaborator Author

Except that the link to the generated pdf is hidden too deep.

This is from an unreleased feature of multiversion I was pointed to: #132 (comment)

I'm okay with it: you have a button with versions, you find old versions and different formats. But I'm working on a big refactoring of the docs (PR not open yet), I'll take it into consideration, to make this v:master button more known.

@Readon Readon merged commit 6a6baac into SpinalHDL:master Nov 17, 2022
@Readon
Copy link
Collaborator

Readon commented Nov 17, 2022

Except that the link to the generated pdf is hidden too deep.

This is from an unreleased feature of multiversion I was pointed to: #132 (comment)

I'm okay with it: you have a button with versions, you find old versions and different formats. But I'm working on a big refactoring of the docs (PR not open yet), I'll take it into consideration, to make this v:master button more known.

Maybe another PR is better to keep the repo's history clean.

@numero-744
Copy link
Collaborator Author

Yea, will be a really big PR on its own, no need to mix it with other things XD

@numero-744 numero-744 deleted the pdf-gen-docker branch November 20, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: generate pdf
2 participants