Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ERR in toWishbone #399

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

martijnbastiaan
Copy link
Contributor

This PR implements handling ERR in toWishbone.

Note that the following may look strange:

  cmdBridge.ready := cmdBridge.valid && (bus.ACK || bus.ERR)

But this is imposed by the Wishbone spec:

Rule 3.45
If a SLAVE supports the [ERR_O] or [RTY_O] signals, then the SLAVE MUST NOT assert more than one of the following signals at any time: [ACK_O], [ERR_O] or [RTY_O].


Questions for reviewers:

  • Is there an example regression test for, say, AXI error handling I could use as a base for a Wishbone test?
  • Where can I add a changelog entry (if applicable)?

@Dolu1990
Copy link
Member

Hi,

Thanks for the fix ^^

Is there an example regression test for, say, AXI error handling I could use as a base for a Wishbone test?

So the issue is that those bridges are more used inside SoC, and tested at a SoC level. There is no proper test for it in VexRIscv repo. Not great.

Where can I add a changelog entry (if applicable)?

So far, the git commits are the logs

Note that i'm now working on VexiiRiscv : https://github.com/SpinalHDL/VexiiRiscv
Aiming for the mooooooon XD

Cheers
Charles

@Dolu1990 Dolu1990 merged commit 457ae5c into SpinalHDL:master Mar 29, 2024
1 check passed
@martijnbastiaan martijnbastiaan deleted the wishbone-err branch March 29, 2024 13:09
@martijnbastiaan
Copy link
Contributor Author

Thanks for the merge!

Note that i'm now working on VexiiRiscv : https://github.com/SpinalHDL/VexiiRiscv

Good luck!!

martijnbastiaan added a commit to clash-lang/clash-vexriscv that referenced this pull request Mar 29, 2024
martijnbastiaan added a commit to clash-lang/clash-vexriscv that referenced this pull request Mar 29, 2024
martijnbastiaan added a commit to clash-lang/clash-vexriscv that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants