Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undriven signal #433

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix undriven signal #433

merged 1 commit into from
Nov 11, 2024

Conversation

7FM
Copy link
Contributor

@7FM 7FM commented Nov 11, 2024

So I am using https://github.com/efabless/openlane2/ to synthesize VexRiscv for SKY130, and I am facing synthesis issues due to an undriven pin:
Verilator Linting:

%Warning-UNDRIVEN: VexRiscv.v:780:23: Signal is not driven: 'IBusSimplePlugin_rspJoin_fetchRsp_isRvc'
                                                                               : ... note: In instance 'top.VexRiscv_inst'
  780 |   wire                IBusSimplePlugin_rspJoin_fetchRsp_isRvc;
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Resulting error: ABC: Error: The network is combinational.

Thanks to verilator's linting, I was able to pin down the signal that is missing an assignment.
However, since I am not familiar with code base, my proposed "fix" might not be semantically correct, but at least fixes the synthesis issues.

For the sake of completeness, this is the openlane config.json that I am using:

{
"DESIGN_NAME": "VexRiscv",
"VERILOG_FILES": "dir::src/*",
"CLOCK_PORT": "clk",
"CLOCK_NET": "clk",
"DESIGN_IS_CORE": false,
"RUN_KLAYOUT_XOR": 0,
"RUN_KLAYOUT_DRC": 0,
"CLOCK_PERIOD": 50,
"FP_CORE_UTIL": 20
}

@Dolu1990
Copy link
Member

Hi,

Can you send me your VexRiscv verilog file ?
Just to check where that signal is used ^^

@7FM
Copy link
Contributor Author

7FM commented Nov 11, 2024

Sure (github does not allow .v uploads... hence the .txt suffix)
Generated with sbt "runMain vexriscv.demo.VexRiscvAhbLite3"
VexRiscv.v.txt
VexRiscv_fixed.v.txt

@Dolu1990
Copy link
Member

Thanks ^^

@Dolu1990 Dolu1990 merged commit 4cf81af into SpinalHDL:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants