Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial check-in #3340

Closed
wants to merge 115 commits into from
Closed

Initial check-in #3340

wants to merge 115 commits into from

Conversation

tlimoncelli
Copy link
Contributor

This is a rewrite of how DNS records get from dnsconfig.js to the DomainConfig.Records ([]*RecordConfig) structure.

What problem are we trying to solve?

  • Current implementation of models.RecordConfig wastes memory. Every new rType adds fileds which are usually unused.
  • The code for record types is scattered all over the code base, making maintenance difficult.
  • Testing record types is difficult.
  • Testing "builders" is extremely difficult.

Solution

  • Move the processing of DNS records (A, MX, SRV, etc) in dnsconfig.js from Javascript to Go
  • Instead of storing a records field's in RecordConfig (which is growing without bounds), store a pointer to a type-specific struct: Different struct for A, MX, SRV, etc.

@tlimoncelli tlimoncelli deleted the branch_gorec_first branch January 10, 2025 14:45
@tlimoncelli tlimoncelli restored the branch_gorec_first branch January 10, 2025 15:41
@tlimoncelli tlimoncelli deleted the branch_gorec_first branch January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant