Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCLOUD: Re-try on 502 errors #3376

Merged
merged 4 commits into from
Jan 16, 2025
Merged

GCLOUD: Re-try on 502 errors #3376

merged 4 commits into from
Jan 16, 2025

Conversation

tlimoncelli
Copy link
Contributor

Issue

502 errors are retry-able after 30 seconds

Rate limit logic error: only kicks in when if err != nil { which I believe is reversed.

Resolution

  • retry 502 errors exactly once
  • Check for the need to rate limit if if err == nil {

@tlimoncelli
Copy link
Contributor Author

CC @riyadhalnur

@tlimoncelli
Copy link
Contributor Author

Hi @riyadhalnur

I added rate limiting in db6ad08 and I think I got the logic wrong. It only kicks in if there was NO error. Does the new code look more correct?

Thanks!

@tlimoncelli
Copy link
Contributor Author

I've observed it kick in and it seems to work.

Sorry for the rush but I'm going to merge this. I'm trying to get a bunch of PRs merged so I can do a release tomorrow. I can fix any problems in follow-up PRs.

@tlimoncelli tlimoncelli merged commit f666af8 into main Jan 16, 2025
20 checks passed
@tlimoncelli tlimoncelli deleted the tlim_gcloud_ratelimit branch January 16, 2025 18:56
tlimoncelli added a commit that referenced this pull request Jan 21, 2025
@tlimoncelli
Squashed commit of the following:
e75c1ac 
commit 901a3ac
Author: Tom Limoncelli <[email protected]>
Date:   Tue Jan 21 14:43:33 2025 -0500

    CHORE: Update dependencies (#3397)

commit 70e9659
Author: Tom Limoncelli <[email protected]>
Date:   Tue Jan 21 14:29:53 2025 -0500

    MSDNS: Provider is failing due to lint fix gone wrong (#3396)

commit 5e15bbe
Author: Jakob Ackermann <[email protected]>
Date:   Sat Jan 18 13:54:37 2025 +0000

    BUG: fetch zones once in ZoneCache (#3394)

commit a631c5b
Author: Kai Schwarz <[email protected]>
Date:   Fri Jan 17 20:15:10 2025 +0100

    CNR: Initial Performance improvement; golint review (#3391)

commit e1c9785
Author: Tom Limoncelli <[email protected]>
Date:   Fri Jan 17 07:11:10 2025 -0500

    CHORE: Update dependencies (#3385)

commit 9e88b6a
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 21:47:10 2025 -0500

    CICD: Make pager tests more visible (#3387)

commit 67db0e2
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 14:41:18 2025 -0500

    GCLOUD: remove (irrelevant) slow test (#3384)

commit c348e35
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 14:32:32 2025 -0500

    GCLOUD: CICD: Skip the pager1201 integration test (#3383)

commit 5cfb907
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 14:17:47 2025 -0500

    TRANSIP: Pause when rate-limited (#3378)

commit f666af8
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 13:56:46 2025 -0500

    GCLOUD: Re-try on 502 errors (#3376)

commit 1a1a4bf
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 12:54:48 2025 -0500

    INWX: Enable SRV to have "." target (#3380)

commit 3556439
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 10:58:11 2025 -0500

    CLOUDFLAREAPI: No longer treat TTL=300 as special (#3368)

    Co-authored-by: Sukka <[email protected]>

commit 89c65b6
Author: Tom Limoncelli <[email protected]>
Date:   Thu Jan 16 10:03:00 2025 -0500

    INWX: Permit "." target for SRV records (#3377)

commit fc2c506
Author: Tom Limoncelli <[email protected]>
Date:   Wed Jan 15 18:28:15 2025 -0500

    CICD: Warn user if -provider does not match profiles.json:TYPE (#3375)

commit 0d5b3c2
Author: Jakob Ackermann <[email protected]>
Date:   Wed Jan 15 22:43:24 2025 +0000

    CLOUDFLARE: adopt ZoneCache (#3373)

commit 2ef2362
Author: Jakob Ackermann <[email protected]>
Date:   Wed Jan 15 20:23:02 2025 +0000

    HETZNER: adopt ZoneCache (#3372)

commit ab00797
Author: Tom Hughes <[email protected]>
Date:   Wed Jan 15 02:07:19 2025 +0000

    FEATURE: Extend PTR magic handling to support RFC4183 names (#3364)

commit 5c9b170
Author: Jakob Ackermann <[email protected]>
Date:   Wed Jan 15 02:05:17 2025 +0000

    FEAT: Add ZoneCache primitive (#3365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tlimoncelli