-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dnspython to 2.6.1 to fix pack CI failure on py3.10/py3.11 #6265
Conversation
30b4c58
to
e1d5990
Compare
What if we just removed dnspython from our requirements files and let pip pick the version? Or, what if we just removed the constraint from |
To clarify: the original reason for pinning |
e1d5990
to
14079d1
Compare
Dropped pinning for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the lockfile was regenerated with these requirements changes (which includes transitive deps). Normally regenerating the lockfile displays a summary of these changes--I like to copy that into a comment on the PR.
arcomplete
3.5.0
->3.5.1
charset-normalizer
3.3.2
->3.4.0
cryptography
43.0.1
->43.0.3
distlib
0.3.8
->0.3.9
dnspython
1.16.0
->2.6.1
greenlet
3.1.0
->3.1.1
prompt-toolkit
3.0.47
->3.0.48
psutil
6.0.0
->6.1.0
redis
5.0.8
->5.1.1
setuptools
75.1.0
->75.2.0
tomli
2.0.1
->2.0.2
tzdata
2024.1
->2024.2
virtualenv
20.26.5
->20.27.0
xmltodict
0.13.0
->0.14.2
Would you please update these in fixed-requirements.txt to match the lockfile?
argcomplete
cryptography
greenlet
prompt-toolkit
psutil
redis
virtualenv
And please update this in the Makefile:
setuptools
Aside: eventually, pants should gain the ability to update only some of the deps instead of regenerating the whole thing. Sorry for the mess in the interim.
If you'd prefer, we can submit these extra fixed-requirements.txt changes in a follow-up PR. Because everything else LGTM. I'm approving this for now, assuming these updates are made in such a follow-up.
Update
dnspython
to v2.6.1 to fix pack CI failing for py3.10 / py3.11 withAttributeError: module 'collections' has no attribute 'MutableMapping'
.