fix: final review feedback

Staffbase · Jan 23, 2025 · d8346de · d8346de
1 parent e442ee7
commit d8346de
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/.github/workflows/template_changeset_release.yml b/.github/workflows/template_changeset_release.yml
@@ -9,15 +9,23 @@ on:
         required: false
         type: string
       publish-script:
-        description: "The file script to run on publish. Defaults to `pnpm release`"
+        description: "The script to run on publish. Defaults to `pnpm release`"
         default: 'pnpm release'
         required: false
         type: string
       version-script:
-        description: "The file script to run for bumping the package versions. Defaults to `pnpm changeset version`"
+        description: "The script to run for bumping the package versions. Defaults to `pnpm changeset version`"
         default: 'pnpm changeset version'
         required: false
         type: string
+      node-registry:
+        description: "The registry to use for Node.js packages."
+        required: false
+        type: string
+      node-registry-scope:
+        description: "The scope to use for Node.js packages."
+        required: false
+        type: string
     secrets:
       app_id:
         required: true
@@ -51,8 +59,8 @@ jobs:
         with:
           node-version-file: ${{ inputs.node-version-file }}
           cache: 'pnpm'
-          registry-url: 'https://npm.pkg.github.com/'
-          scope: '@staffbase'
+          registry-url: ${{ inputs.node-registry }}
+          scope: ${{ inputs.node-registry-scope }}
 
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile --ignore-scripts

diff --git a/README.md b/README.md
@@ -146,11 +146,11 @@ jobs:
   changeset-release:
     uses: Staffbase/gha-workflows/.github/workflows/[email protected]
     with:
-      # optional, defaults to `.nvmrc`
+      # optional: The file containing the Node.js version to use, defaults to .nvmrc
       node-version-file: '.node-version'
-      # optional, defaults to `pnpm release`
+      # optional: The script to run on publish. Defaults to `pnpm release`
       publish-script: 'pnpm publish'
-      # optional, defaults to `pnpm changeset version`
+      # optional: The script to run for bumping the package versions. Defaults to `pnpm changeset version`
       version-script: 'pnpm version'
     secrets:
       # identifier of the GitHub App for authentication