Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix quarterly patch version #216

Merged
merged 2 commits into from
Jan 24, 2024
Merged

🐛 Fix quarterly patch version #216

merged 2 commits into from
Jan 24, 2024

Conversation

flaxel
Copy link
Contributor

@flaxel flaxel commented Jan 24, 2024

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

  • add check for weekly release to change patch version

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@flaxel flaxel added bug Something isn't working patch Pull request with little updates labels Jan 24, 2024
@flaxel flaxel requested a review from a team as a code owner January 24, 2024 07:28
soemo
soemo requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@soemo soemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have format quarterly, and a new quarter starts we need to set the counter to 0 too

@flaxel flaxel force-pushed the fix-weekly-release branch from db1d710 to 0259b51 Compare January 24, 2024 07:40
@flaxel flaxel requested a review from soemo January 24, 2024 07:40
@flaxel flaxel merged commit 7c2d731 into main Jan 24, 2024
2 checks passed
@flaxel flaxel deleted the fix-weekly-release branch January 24, 2024 07:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soemo soemo soemo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working patch Pull request with little updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaxel @soemo