Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom tag in gitops template #266

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

askvinni
Copy link
Contributor

@askvinni askvinni commented Jun 28, 2024

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

see Staffbase/gitops-github-action#89

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@askvinni askvinni requested a review from a team as a code owner June 28, 2024 14:52
Copy link
Contributor

github-actions bot commented Jun 28, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@askvinni
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@askvinni
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Jun 28, 2024
@flaxel flaxel added enhancement New feature or request minor Pull requests with new features labels Jul 1, 2024
Copy link
Contributor

@flaxel flaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the change correctly, the custom tag is always preferred. Does this mean that you only create releases with the custom tag? Otherwise, you use the normal logic? 🤔 If this is the case, I would adapt the documentation as it only affects the prod tag.

@askvinni
Copy link
Contributor Author

askvinni commented Jul 1, 2024

If I understand the change correctly, the custom tag is always preferred. Does this mean that you only create releases with the custom tag? Otherwise, you use the normal logic? 🤔 If this is the case, I would adapt the documentation as it only affects the prod tag.

Correct; we have a monorepo and want to tag with prefix/version, and use the action to release code within the prefix folder with version version, so an initial step extracts both variables and the gitops workflow uses them.

I'll update the docs and rerequest review.

@askvinni askvinni requested a review from flaxel July 1, 2024 07:58
README.md Outdated Show resolved Hide resolved
@askvinni askvinni merged commit 6e131e9 into main Jul 1, 2024
7 checks passed
@askvinni askvinni deleted the gitops-support-custom-tag branch July 1, 2024 08:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request minor Pull requests with new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants