장소 신고하기 API 구현 #370
Merged
장소 신고하기 API 구현 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeniuus
approved these changes
Aug 18, 2024
| @@ -598,6 +598,27 @@ paths: | |||
| required: | |||
| - placeAccessibilityComment | |||
|
|
|||
| /reportAccessibility: | |||
There was a problem hiding this comment.
기획에 대해 잘 모르는데, reportPlaceAccessibility랑 reportBuildingAccessibility가 구분되지 않아도 괜찮나요?
There was a problem hiding this comment.
일단 지금 앱 구현에서는 따로 구분되어 있는거 같지 않아서 Place 로 합쳐놨는데 한번 여쭤볼게요!
| package club.staircrusher.accessibility.application.port.out | ||
|
|
||
| // TODO: push 기능 생기면 그거랑 합치기 | ||
| interface NotificationService { |
There was a problem hiding this comment.
notification이 꽤나 여러가지 의미를 가지는 것 같아서, 걍 SlackService가 더 나을지도? ㅋㅋ
| properties: SlackNotificationProperties | ||
| ) : NotificationService { | ||
| private val logger = KotlinLogging.logger {} | ||
| private val slackService = createExternalApiService<SlackService>( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist