Genesis improvements #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2019
Closed
|
Can you make a PR in garnet that reflect this change? |
|
Also how is it related to phanrahan/magma#367? I didn't see any changes here reflecting the |
|
@rsetaluri Is this PR still relevant? |
|
Yes, what we did was just to revert to the previous verilog wrapping flow. I will work on getting this working on the side. |
rsetaluri
added a commit
to StanfordAHA/garnet
that referenced
this pull request
May 7, 2019
Updated memory core genesis wrapper test for new verilog/genesis wrapping methodology. Depends on StanfordAHA/gemstone#20.
rsetaluri
force-pushed
the
genesis-improvements
branch
from
3e77edf to
470d3e9
Compare
|
@rsetaluri What is the status on this? |
Kuree
force-pushed
the
master
branch
4 times, most recently
from
3ed5dc7 to
2b36a7e
Compare
Kuree
force-pushed
the
master
branch
2 times, most recently
from
6b36684 to
88a6bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Capture entire genesis output
-- Cache genesis generators
Removes need to do any caching logic in downstream tools (gemstone does it for you). Also don't need to do any hacky copying of files etc. It is all captured in
DeclareFromVerilogFileused in (run_genesis) now.