Skip to content

Commit

Permalink
Text edots
Browse files Browse the repository at this point in the history
Minor text edits made to the "Welcome" page, as well as removal of the "Learn more..." link.
  • Loading branch information
alexaaalami committed Jun 21, 2024
1 parent b2742b0 commit a89556f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 16 deletions.
4 changes: 2 additions & 2 deletions OwnYourData/Home.swift
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ struct HomeView: View {

@MainActor @ViewBuilder private var welcome: some View {
if let givenName = account?.details?.name?.givenName {
Text("Welcome,\n\(givenName)")
Text("Welcome,\n\(givenName).")

Check warning on line 80 in OwnYourData/Home.swift

View check run for this annotation

Codecov / codecov/patch

OwnYourData/Home.swift#L80

Added line #L80 was not covered by tests
} else {
Text("Welcome!")
Text("Welcome.")
}
}
}
Expand Down
18 changes: 9 additions & 9 deletions OwnYourData/Instructions/InstructionsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ struct InstructionsView: View {
Text("FHIR_RESOURCES_VIEW_NO_RESOURCES")
.frame(maxWidth: .infinity)
.multilineTextAlignment(.leading)
Text("Learn More ...")
.foregroundColor(.accentColor)
//Text("Learn More ...")

Check failure on line 26 in OwnYourData/Instructions/InstructionsView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint

Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
// .foregroundColor(.accentColor)
}
.padding()
.background(
Expand All @@ -33,12 +33,12 @@ struct InstructionsView: View {
.shadow(radius: 5)
)
.padding()
.contentShape(Rectangle())
.onTapGesture {
displayInstructions.toggle()
}
.sheet(isPresented: $displayInstructions) {
AddRecordInstructView()
}
//.contentShape(Rectangle())

Check failure on line 36 in OwnYourData/Instructions/InstructionsView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint

Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
//.onTapGesture {

Check failure on line 37 in OwnYourData/Instructions/InstructionsView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint

Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
// displayInstructions.toggle()
//}

Check failure on line 39 in OwnYourData/Instructions/InstructionsView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint

Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
//.sheet(isPresented: $displayInstructions) {

Check failure on line 40 in OwnYourData/Instructions/InstructionsView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint

Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
// AddRecordInstructView()
//}

Check failure on line 42 in OwnYourData/Instructions/InstructionsView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint

Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
}
}
7 changes: 2 additions & 5 deletions OwnYourData/Resources/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Find National Cancer Institute supported trials.\n\nWe noticed that you haven't saved any health records on your phone yet.\n\nPlease follow the instructions to retrieve your health records: [Apple Support - View health records on your iPhone or iPod touch](https://support.apple.com/en-us/HT208680).\n\nYou can find a list of supported institutions at [Apple Support - Institutions that support health records on iPhone and iPod touch](https://platform.openai.com/account/api-keys).\n\nPlease ensure that OwnYourData has access to your health records in the Apple Health App. You can find these settings in the privacy section of your profile in Apple Health."
"value" : "We noticed that you haven't saved any health records on your phone yet.\n\nPlease follow these [instructions](https://support.apple.com/en-us/HT208680).\n to retrieve your health records.\n\nYou can find a list of supported institutions at [Apple Support - Institutions that support health records on iPhone and iPod touch](https://platform.openai.com/account/api-keys).\n\nPlease ensure that OwnYourData has access to your health records in the Apple Health App. You can find these settings in the privacy section of your profile in Apple Health."
}
}
}
Expand Down Expand Up @@ -114,9 +114,6 @@
},
"Learn More" : {

},
"Learn More ..." : {

},
"License Information" : {

Expand Down Expand Up @@ -295,7 +292,7 @@
"Use the OwnYourData algorithm to match you to possible NCI trials." : {

},
"Welcome,\n%@" : {
"Welcome,\n%@!" : {

},
"Welcome!" : {
Expand Down

0 comments on commit a89556f

Please sign in to comment.