-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AccountSetup to be created with async function to handle completeness of the account setup #73
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 84.36% 83.74% -0.61%
==========================================
Files 120 120
Lines 5221 5158 -63
==========================================
- Hits 4404 4319 -85
- Misses 817 839 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work 🚀
I think the PR is generally in a good shape. Just had a few comments and ideas that discusses some of the detailed design of this PR.
318ed30
to
71b8a89
Compare
I reverted the changes that are needed in ENGAGE-HF and will open a different PR instead, since this might still be a nice addition, but actually isn't needed urgently anymore. Feel free to keep this open / ask for adaptions though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work here @pauljohanneskraft! I had a comment about the API surface were we could improve the naming; apart from this the change looks good and once @Supereg's comment are addressed we can merge this as a nicer generalization of this feature.
Allow AccountSetup to be created with async throwing function to handle completeness of the account setup
♻️ Current situation & Problem
When an account setup is successful, one may want to run additional code that is async and throwing to finish the account setup completely.
Specifically in ENGAGE-HF, we need to call a Firebase function when a new account has been created before the account can actually be used.
⚙️ Release Notes
setupComplete
parameter inAccountSetup
to be async-throwing.📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
✅ Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: