Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align interface to Android #31

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

pauljohanneskraft
Copy link

@pauljohanneskraft pauljohanneskraft commented Sep 25, 2024

Align interface to Android

♻️ Current situation & Problem

During the implementation of SpeziContact for Android, we discussed the following changes to the interface, where iOS may benefit as well.

See StanfordSpezi/SpeziKt#104

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft self-assigned this Sep 25, 2024
@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (f50a5b8) to head (52ccde6).

Files with missing lines Patch % Lines
...urces/SpeziContact/Contact Views/ContactView.swift 12.50% 7 Missing ⚠️
Sources/SpeziContact/Models/ContactOption.swift 87.28% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   78.69%   77.06%   -1.62%     
==========================================
  Files           4        4              
  Lines         319      340      +21     
==========================================
+ Hits          251      262      +11     
- Misses         68       78      +10     
Flag Coverage Δ
77.06% <77.78%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...urces/SpeziContact/Contact Views/ContactView.swift 76.15% <12.50%> (-1.99%) ⬇️
Sources/SpeziContact/Models/ContactOption.swift 83.91% <87.28%> (-3.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50a5b8...52ccde6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant