Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in version check command #21

Merged
merged 26 commits into from
Jul 24, 2024
Merged

Fix syntax error in version check command #21

merged 26 commits into from
Jul 24, 2024

Conversation

Vicbi
Copy link
Collaborator

@Vicbi Vicbi commented Jul 8, 2024

Fix syntax error in version check command

♻️ Current situation & Problem

This PR addresses the syntax error in the Check if version already exists on PyPI/Test PyPI step of the GitHub Actions workflow. The curl and jq command is now properly formatted and broken into multiple lines for better readability.

⚙️ Release Notes

Corrected syntax and broke the curl and jq command into multiple lines in the Check if version already exists on PyPI/Test PyPI step.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (acde1bb) to head (341a091).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   83.51%   82.87%   -0.63%     
==========================================
  Files          16       16              
  Lines        1564     1582      +18     
==========================================
+ Hits         1306     1311       +5     
- Misses        258      271      +13     
Flag Coverage Δ
unittests 82.87% <91.67%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
..._pipeline/data_access/firebase_fhir_data_access.py 79.29% <100.00%> (ø)
...peline/data_flattening/fhir_resources_flattener.py 87.87% <100.00%> (ø)
tests/test_data_access.py 99.09% <100.00%> (+0.01%) ⬆️
...zi_data_pipeline/data_exploration/data_explorer.py 68.67% <93.75%> (-4.01%) ⬇️
tests/test_data_exploration.py 97.12% <86.67%> (-1.80%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acde1bb...341a091. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @Vicbi and fixing the deployment issues.

One thing that I also noticed is that we also don't have the documentation deployment to a GitHub page anymore. Not sure where this was lost exactly but it would be great to get this back to ensure that we deploy our documentation to the GitHub page to point people to all the great code documentation you have written 🚀

@Vicbi
Copy link
Collaborator Author

Vicbi commented Jul 8, 2024

Thanks @PSchmiedmayer for pointing out to the documentation deployment! I need to investigate why this happened.

In addition, it looks like there is an issue with the trusted publisher leading to this error * invalid-publisher: valid token, but no corresponding publisher (All lookup strategies exhausted).

I was wondering whether we need to update the trusted publisher configuration on the PyPI account to reflect the new repository name.

@PSchmiedmayer
Copy link
Member

@Vicbi You are right; that must be the issue. I updated the repo name in the testing and production version of pypi.org for the StanfordSpezi account 🚀

@PSchmiedmayer
Copy link
Member

Thank you for re-adding the documentation deployment 👍

@Vicbi
Copy link
Collaborator Author

Vicbi commented Jul 8, 2024

Awesome! Thank you for updating the configuration @PSchmiedmayer !

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @Vicbi; looks great and happy to see this merged 🚀

.github/workflows/publish-to-pypi.yml Show resolved Hide resolved
tests/test_data_exploration.py Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jul 17, 2024
@Vicbi Vicbi merged commit edc0605 into main Jul 24, 2024
17 checks passed
@Vicbi Vicbi deleted the fix-publish-workflow branch July 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants