Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for visionOS, macOS and tvOS #4

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 1, 2024

Add support for visionOS, macOS and tvOS

♻️ Current situation & Problem

This PR adds support for visionOS, macOS and tvOS. These are not major changes and only required changes within the Package.swift file.

⚙️ Release Notes

  • Add support for visionOS, macOS and tvOS

📚 Documentation

✅ Testing

We are currently testing iOS, watchOS and visionOS in CI.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1e6d4c) 95.32% compared to head (1c13b97) 95.32%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           9        9           
  Lines         128      128           
=======================================
  Hits          122      122           
  Misses          6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e6d4c...1c13b97. Read the comment docs.

@Supereg Supereg requested a review from PSchmiedmayer February 1, 2024 04:23
@Supereg Supereg marked this pull request as ready for review February 1, 2024 04:23
@PSchmiedmayer
Copy link
Member

Thank you @Supereg! It would be great if we add some CI setup from https://github.com/StanfordBDHG/SwiftPackageTemplate to this repo to fully validate the functionality. We might need to add tvOS to https://github.com/StanfordBDHG/SwiftPackageTemplate before that.

In the same flow, it would be great if we can add all the badges to the README here that are also in https://github.com/StanfordBDHG/SwiftPackageTemplate.

@Supereg
Copy link
Member Author

Supereg commented Feb 2, 2024

I just added tvOS and macOS builds for the Swift package. Also I added back CodeQL support with this PR 👍

@Supereg
Copy link
Member Author

Supereg commented Feb 2, 2024

@PSchmiedmayer something I noticed. We specified Apple Watch Series 8 previously and as it doesn't exist in the toolchain anymore (now Series 9) it silently used a different platform (in this case macOS). We might want to see if we can move this into the action itself at some point.

@Supereg Supereg enabled auto-merge (squash) February 2, 2024 22:29
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @Supereg! 🚀

CITATION.cff Show resolved Hide resolved
@Supereg Supereg merged commit 0346857 into main Feb 4, 2024
12 checks passed
@Supereg Supereg deleted the feature/platform-support branch February 4, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants