-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for visionOS, macOS and tvOS #4
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 9 9
Lines 128 128
=======================================
Hits 122 122
Misses 6 6 Continue to review full report in Codecov by Sentry.
|
Thank you @Supereg! It would be great if we add some CI setup from https://github.com/StanfordBDHG/SwiftPackageTemplate to this repo to fully validate the functionality. We might need to add tvOS to https://github.com/StanfordBDHG/SwiftPackageTemplate before that. In the same flow, it would be great if we can add all the badges to the README here that are also in https://github.com/StanfordBDHG/SwiftPackageTemplate. |
I just added tvOS and macOS builds for the Swift package. Also I added back CodeQL support with this PR 👍 |
@PSchmiedmayer something I noticed. We specified Apple Watch Series 8 previously and as it doesn't exist in the toolchain anymore (now Series 9) it silently used a different platform (in this case macOS). We might want to see if we can move this into the action itself at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements @Supereg! 🚀
Add support for visionOS, macOS and tvOS
♻️ Current situation & Problem
This PR adds support for visionOS, macOS and tvOS. These are not major changes and only required changes within the Package.swift file.
⚙️ Release Notes
📚 Documentation
✅ Testing
We are currently testing iOS, watchOS and visionOS in CI.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: