Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global RuntimeConfiguration #6

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add global RuntimeConfiguration #6

merged 2 commits into from
Feb 27, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Feb 27, 2024

Add global RuntimeConfiguration

♻️ Current situation & Problem

Within the SpeziChat project, we discovered the need for a global runtime configuration object that holds certain testing support variables (e.g. about the debug mode).

⚙️ Release Notes

  • Add global RuntimeConfiguration accessible via the TestingSupport SPI target.

📚 Documentation

Added proper documentation

✅ Testing

No new test cases written

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Feb 27, 2024
@philippzagar philippzagar self-assigned this Feb 27, 2024
@philippzagar philippzagar changed the title Application Environment state Add global Application Environment state Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (d1e6d4c) to head (5cf4fc7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           9        9           
  Lines         128      128           
=======================================
  Hits          122      122           
  Misses          6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0346857...5cf4fc7. Read the comment docs.

@philippzagar philippzagar changed the title Add global Application Environment state Add global RuntimeConfiguration Feb 27, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the naming configuration and improvements. The setup looks great and addresses the core need.

@philippzagar philippzagar merged commit 662f25d into main Feb 27, 2024
12 checks passed
@philippzagar philippzagar deleted the feat/global-state branch February 27, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants