Avoid double negations to check for cancellation #83
Labels
good first issue
Good for newcomers
Comments
1 task
philippzagar
pushed a commit
that referenced
this issue
Feb 15, 2025
# Remove double negations for `checkCancellation` function ## ♻️ Current situation & Problem As mentionned in issue #83 as well as in the PR [#81 (discussion)](#81 (comment)), the SpeziLLM package is currently using a double negation (`guard` followed by `!`) for every `checkCancellation()` function call. As double negations make the code harder to read, we could use `if` instead. ## ⚙️ Release Notes * Remove the double negations for `checkCancellation` by replacing the `guard` statements that are followed by a not operator into an `if` statement. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
|
Closed by #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refactor the check for cancellation
checkCancellationso that we don't have a double negation (guard&!), throughout the whole framework.Originally posted by @jdisho in #81 (comment)
The text was updated successfully, but these errors were encountered: