-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double negations for checkCancellation function #98
Remove double negations for checkCancellation function #98
Conversation
Nice work @Seb-Ltz! LGTM 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Seb-Ltz, thanks for the quick fix!
@Seb-Ltz Seems like the Vision Pro UI tests timed out in the CI (sometimes happens, I retriggered the job, should hopefully pass in the second run. |
Closes #83 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 39.12% 39.12%
=======================================
Files 64 64
Lines 2357 2357
=======================================
Hits 922 922
Misses 1435 1435
Continue to review full report in Codecov by Sentry.
|
Remove double negations for
checkCancellation
function♻️ Current situation & Problem
As mentionned in issue #83 as well as in the PR #81 (discussion), the SpeziLLM package is currently using a double negation (
guard
followed by!
) for everycheckCancellation()
function call. As double negations make the code harder to read, we could useif
instead.⚙️ Release Notes
checkCancellation
by replacing theguard
statements that are followed by a not operator into anif
statement.📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: