-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup of repository #2
Conversation
@PSchmiedmayer I think what's left here is a proper DOI as well as the push to the Swift Package Index (the latter one can probably only be done after merging to |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
============================================
- Coverage 100.00% 18.41% -81.59%
============================================
Files 1 2 +1
Lines 1 163 +162
============================================
+ Hits 1 30 +29
- Misses 0 133 +133
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the code to this repo from Spezi ML and adding all the documentation surrounding it.
I had a few comments that would be great to be addressed before we merge the PR. The overall PR looks very great and all the documentation added is more than appreciated! 🚀
Sources/SpeziSpeechSynthesizer/SpeziSpeechSynthesizer.docc/SpeziSpeechSynthesizer.md
Outdated
Show resolved
Hide resolved
@PSchmiedmayer PR should be ready for another review round! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you! 🚀
@PSchmiedmayer Perfect, then please go ahead and merge this PR as the code cov + markdown link checker merge checks are failing (this is expected)! 🚀 |
Thank you! Merged the PR, tagged a release, and submitted it to the Swift Package Index. Can then add the elements to the README including a DOI and everything else once all that is processed 👍 |
Initial setup of repository
♻️ Current situation & Problem
Currently, the repo is empty except for template code.
⚙️ Release Notes
SpeziSpeech
repo which previously was a target in the SpeziML repo📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: