Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup of repository #2

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Initial setup of repository #2

merged 11 commits into from
Nov 17, 2023

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Nov 13, 2023

Initial setup of repository

♻️ Current situation & Problem

Currently, the repo is empty except for template code.

⚙️ Release Notes

  • Initial setup of the SpeziSpeech repo which previously was a target in the SpeziML repo
  • Upgrade to Spezi v0.8
  • Improved README and documentation via DocC

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Nov 13, 2023
@philippzagar philippzagar self-assigned this Nov 13, 2023
@philippzagar
Copy link
Member Author

philippzagar commented Nov 13, 2023

@PSchmiedmayer I think what's left here is a proper DOI as well as the push to the Swift Package Index (the latter one can probably only be done after merging to main, the links to the index are already set correctly, that's thy the Markdown Link Check fails).

@philippzagar philippzagar changed the title Initial setup of application Initial setup of repository Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2 (b6e8568) into main (4980e52) will decrease coverage by 81.59%.
The diff coverage is 18.41%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              main       #2       +/-   ##
============================================
- Coverage   100.00%   18.41%   -81.59%     
============================================
  Files            1        2        +1     
  Lines            1      163      +162     
============================================
+ Hits             1       30       +29     
- Misses           0      133      +133     
Files Coverage Δ
...ces/SpeziSpeechSynthesizer/SpeechSynthesizer.swift 12.97% <12.97%> (ø)
...urces/SpeziSpeechRecognizer/SpeechRecognizer.swift 21.11% <21.11%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4980e52...b6e8568. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the code to this repo from Spezi ML and adding all the documentation surrounding it.

I had a few comments that would be great to be addressed before we merge the PR. The overall PR looks very great and all the documentation added is more than appreciated! 🚀

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
Sources/SpeziSpeechRecognizer/SpeechRecognizer.swift Outdated Show resolved Hide resolved
Tests/UITests/UITests.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Tests/UITests/TestApp/SpeechTestView.swift Show resolved Hide resolved
@philippzagar
Copy link
Member Author

@PSchmiedmayer PR should be ready for another review round!

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! 🚀

@philippzagar
Copy link
Member Author

philippzagar commented Nov 16, 2023

@PSchmiedmayer Perfect, then please go ahead and merge this PR as the code cov + markdown link checker merge checks are failing (this is expected)! 🚀
Feel free to also go ahead and tag a release!

@PSchmiedmayer PSchmiedmayer merged commit f629d66 into main Nov 17, 2023
6 of 9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feat/init-setup branch November 17, 2023 00:22
@PSchmiedmayer
Copy link
Member

Thank you! Merged the PR, tagged a release, and submitted it to the Swift Package Index. Can then add the elements to the README including a DOI and everything else once all that is processed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants