Validate Modifier for Predicates #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @AdritRao, this might be helpful for StanfordSpezi/SpeziOnboarding#54 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 80.37% 81.12% +0.75%
==========================================
Files 44 44
Lines 1304 1308 +4
==========================================
+ Hits 1048 1061 +13
+ Misses 256 247 -9
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate Modifier for Predicates
♻️ Current situation & Problem
SpeziValidation currently provides the
validate(input:rules:)modifier to validateString-based inputs using SpeziValidation. This PR extends this functionality toBoolexpressions. The newvalidate(_:message:)modifier can be used to validate all sorts of boolean conditions and supply a validation failure reason with it.⚙️ Release Notes
validate(_:message:)modifier to validate bool expressions.📚 Documentation
Documentation was updated to highlight the new modifier.
✅ Testing
TBA
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: