Add InfoButton for list rows #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 74.91% 75.44% +0.54%
==========================================
Files 52 54 +2
Lines 1586 1657 +71
==========================================
+ Hits 1188 1250 +62
- Misses 398 407 +9
Continue to review full report in Codecov by Sentry.
|
Supereg
force-pushed
the
feature/list-info-button
branch
from
be12cbb to
d4cc1af
Compare
Supereg
added a commit
to StanfordSpezi/SpeziDevices
that referenced
this pull request
Dec 23, 2024
# Decompose Nearby Device Row ## ♻️ Current situation & Problem The `NearbyDeviceRow` was a monolith-style view that encompassed all functionality without a lot of configuration possibilities to vitalizes a nearby device in, e.g., a Bluetooth scanning view. This design is not really flexible if you want to show your own information or want to adjust the layout. Previously you were forced to write your own view completely from scratch. This PR decomposes the view into multiple subview allowing you to build your custom `NearbyDeviceRow`-like experience without reinventing the wheel completely. The new `PeripheralLabel`, `PeripheralSecondaryLabel`, and `InfoButton` views (see StanfordSpezi/SpeziViews#50) allow you to fully customize the appearance of your `NearbyDeviceRow`. ## ⚙️ Release Notes * Decompose the `NearbyDeviceRow` into `PeripheralLabel`, `PeripheralSecondaryLabel`, and `InfoButton` views for greater customizability. ## 📚 Documentation Added new views to the DocC documentation target. ## ✅ Testing The new tests are implicitly tested via the `NearbyDeviceRow`. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
1 task
Supereg
added a commit
that referenced
this pull request
Jan 19, 2025
# improve `onPreferenceChange` closure MainActor handling ## ♻️ Current situation & Problem In response to Apple changing the `onPreferenceChange` API to no longer MainActor-constrain its closure parameter, #48 and #50 updated all `onPreferenceChange` calls to either schedule the change onto the MainActor, or (in some cases) check if the closure is being called on the MainActor, and then run it directly. This PR fixes this, by using the `runOrScheduleOnMainActor` function from SpeziFoundation ## ⚙️ Release Notes - Improve MainActor interactions in `onPreferenceChange` closures. ## 📚 Documentation n/a ## ✅ Testing There are no dedicated new tests but these changes do in fact fix tests elsewhere. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Andreas Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InfoButton for list rows
♻️ Current situation & Problem
This PR adds a new icon-only
InfoButtonthat is useful in List views to provide additional context to a row element.⚙️ Release Notes
InfoButton.📚 Documentation
Added the new button to the documentation catalog.
✅ Testing
Tested via UI tests.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: