-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new OptionSetPicker #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, looks really cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic! 🚀 Only some super nitty styling things.
ca942f3
to
7be65b5
Compare
@PSchmiedmayer some runners (in this case runner 7) seem to have a problem with the software keyboard not popping up. We had that on iPhone sometimes too. see https://github.com/StanfordSpezi/SpeziViews/actions/runs/12877056182/job/35900963614?pr=53 any chance to his might be a configuration issue? |
Hmm, good question. Let me double-check this on the runner 👍 |
@Supereg I took a look at the runners and ensured that the connection to a hardware keyboard is disabled across all iOS simulators. Hope this fixes the issue. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 75.46% 76.68% +1.22%
==========================================
Files 54 55 +1
Lines 1642 1822 +180
==========================================
+ Hits 1239 1397 +158
- Misses 403 425 +22
Continue to review full report in Codecov by Sentry.
|
Add new option set picker
♻️ Current situation & Problem
This PR adds a new view that makes it easier to work with OptionSet as the selection of a Picker view. SwiftUI
Picker
doesn't natively support multi-selection picker. TheOptionSetPicker
does that by facilitating theOptionSet
protocol.Sadly we cannot fully re-use
PickerStyles
and needed to create our own enum-based solution. Currently we support rendering the picker as amenu
or ainline
view like, e.g., in aList
.⚙️ Release Notes
OptionSetPicker
view.📚 Documentation
Added documentation and added it to the DocC catalog.
✅ Testing
Added new UI tests.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: