[Bugfix] Fix thread name and log (#290) (#292)

Signed-off-by: redscarf <[email protected]>
StarRocks · Oct 13, 2023 · c509c05 · c509c05
1 parent ca3add6
commit c509c05
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...cks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/DefaultStreamLoader.java b/...cks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/DefaultStreamLoader.java
@@ -391,7 +391,7 @@ protected String parseHttpResponse(String requestType, String db, String table,
         if (307 == code) {
             String errorMsg = String.format("Request %s failed because http response code is 307 which means 'Temporary Redirect'. " +
                     "This can happen when FE responds the request slowly , you should find the reason first. The reason may be " +
-                    "StarRocks FE/Flink GC, network delay, or others. db: %s, table: %s, label: %s, response status line: %s",
+                    "StarRocks FE/Flink/Spark GC, network delay, or others. db: %s, table: %s, label: %s, response status line: %s",
                     requestType, db, table, label, response.getStatusLine());
             log.error("{}", errorMsg);
             throw new StreamLoadFailException(errorMsg);

diff --git a/...stream-load-sdk/src/main/java/com/starrocks/data/load/stream/TransactionStreamLoader.java b/...stream-load-sdk/src/main/java/com/starrocks/data/load/stream/TransactionStreamLoader.java
@@ -270,7 +270,7 @@ public boolean commit(StreamLoadSnapshot.Transaction transaction) {
             // there are many corner cases that can lead to non-ok status. some of them are
             // 1. TXN_NOT_EXISTS: transaction timeout and the label is cleanup up
             // 2. Failed: the error message can be "has no backend", The case is that FE leader restarts, and after
-            //    that commit the transaction repeatedly because flink job continues failover for some reason , but
+            //    that commit the transaction repeatedly because flink/spark job continues failover for some reason , but
             //    the transaction actually success, and this commit should be successful
             // To reduce the dependency for the returned status type, always check the label state
             String labelState = getLabelState(host, transaction.getDatabase(), transaction.getTable(), transaction.getLabel(), Collections.emptySet());

diff --git a/...-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/v2/StreamLoadManagerV2.java b/...-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/v2/StreamLoadManagerV2.java
@@ -223,14 +223,14 @@ public void init() {
                         }
                     }
                 }
-            }, "Flink-StarRocks-Sink-Manager");
+            }, "StarRocks-Sink-Manager");
             manager.setDaemon(true);
             manager.start();
             manager.setUncaughtExceptionHandler((t, ee) -> {
                 LOG.error("StarRocks-Sink-Manager error", ee);
                 e = ee;
             });
-            LOG.info("Flink-StarRocks-Sink-Manager start, enableAutoCommit: {}, streamLoader: {}, {}",
+            LOG.info("StarRocks-Sink-Manager start, enableAutoCommit: {}, streamLoader: {}, {}",
                     enableAutoCommit, streamLoader.getClass().getName(), EnvUtils.getGitInformation());
 
             streamLoader.start(properties, this);