-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Improve the format and language of the doc for sink #275
Conversation
docs/content/connector-sink.md
Outdated
|
||
## Version requirements | ||
|
||
| Connector | Flink | StarRocks | Java | Scala | | ||
|-----------|--------------------------|---------------| ---- |-----------| | ||
| 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.1 and later | 8 | 2.11,2.12 | | ||
| 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.5 and later| 8 | 2.11,2.12 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
版本这边是不是可以写sr 2.5 及以后
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest not. Flink connector has been used for a long time, and there are still a lot of users using SR 2.3 and before. It will confuse them if we say only support since 2.5
docs/content/connector-sink.md
Outdated
|
||
## Version requirements | ||
|
||
| Connector | Flink | StarRocks | Java | Scala | | ||
|-----------|--------------------------|---------------| ---- |-----------| | ||
| 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.1 and later | 8 | 2.11,2.12 | | ||
| 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.5 and later| 8 | 2.11,2.12 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest not. Flink connector has been used for a long time, and there are still a lot of users using SR 2.3 and before. It will confuse them if we say only support since 2.5
docs/content/connector-sink.md
Outdated
The Flink connector supports DataStream API, Table API & SQL, and Python API. | ||
|
||
The Flink connector boasts a higher and more stable performance than [flink-connector-jdbc](https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/jdbc/) provided by Apache Flink®. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about merge these two lines to one line?
docs/content/connector-sink.md
Outdated
| table-name | Yes | NONE | The name of the table that you want to use to load data into StarRocks. | | ||
| username | Yes | NONE | The username of the account that you want to use to load data into StarRocks. | | ||
| table-name | Yes | NONE | The name of the table that you want to use to load data into StarRocks. | | ||
| username | Yes | NONE | The username of the account that you want to use to load data into StarRocks. The account must have load permissions on the StarRocks table. See [User privileges](https://docs.starrocks.io/en-us/latest/administration/User_privilege). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need SELECT
privileges
) Signed-off-by: hellolilyliuyi <[email protected]>
) Signed-off-by: hellolilyliuyi <[email protected]>
Signed-off-by: hellolilyliuyi <[email protected]>
Signed-off-by: hellolilyliuyi <[email protected]>
What type of PR is this:
Which issues of this PR fixes :
Fixes #
Problem Summary(Required) :
Checklist: