Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Prepare/commit transaction stream load asynchronously #328

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented Dec 29, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #
For transaction stream load at at-least-once mode, only load phase is executed asynchronously in a thread pool whose size is controlled by sink.io.thread-count , but the prepare/commit phase is executed in the single thread used for schedule, and it can block the schedule thread if prepare/commit takes much time. For multiple tables case, this can prevent to schedule other tables to load/prepare/commit, and lead to performance issue. So we make the prepare/commit also asynchronous.

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

@banmoy banmoy changed the title [Enhancement] Commit transaction stream load asynchronously [Enhancement] Prepare/commit transaction stream load asynchronously Dec 29, 2023
@banmoy banmoy merged commit 7fe8cd2 into StarRocks:main Dec 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants