[Enhancement] Synchronize ddl schema change to Starrocks by parsing json #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
banmoy
changed the title
banmoy
reviewed
Mar 20, 2024
| @@ -79,6 +80,10 @@ public void create(StreamExecutionEnvironment env, String database, Configuratio | |||
| this.excludingPattern = excludingTables == null ? null : Pattern.compile(excludingTables); | |||
| this.sinkConfig = sinkConfig; | |||
| this.tableConfig = tableConfig == null ? new HashMap<>() : tableConfig; | |||
|
|
|||
| if (!this.tableConfig.containsKey(FAST_SCHEMA_EVOLUTION)) { | |||
There was a problem hiding this comment.
If StarRocks version is before 3.2, this will lead to create table fail
There was a problem hiding this comment.
thoughtful，replace it with boolean. this boolean will control whether to execute schemachange
chenhaifengkeda
force-pushed
the
ddl
branch
2 times, most recently
from
b6b760d
to
7b7a65a
Compare
…son (StarRocks#337) Signed-off-by: chenhaifengkeda <[email protected]>
banmoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
Checklist: