Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support partial refresh in text based mv rewrite #56166

Merged
merged 3 commits into from
Feb 28, 2025
Merged

[Enhancement] Support partial refresh in text based mv rewrite #56166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f29d6da
Support partial refresh in text based mv rewrite
LiShuMing Feb 21, 2025
14c72fe
fix bugs
LiShuMing Feb 24, 2025
1dbff20
fix bugs
LiShuMing Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fe/fe-core/src/main/java/com/starrocks/sql/optimizer/QueryOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,11 @@ public OptExpression optimize(OptExpression logicOperatorTree, PhysicalPropertyS
try (Timer ignored = Tracers.watchScope("MVTextRewrite")) {
logicOperatorTree = new TextMatchBasedRewriteRule(context.getConnectContext(), context.getStatement(),
context.getMvTransformerContext()).transform(logicOperatorTree, context).get(0);
// NOTE: PruneColum rules will not care projection required columns, so separate project after text match based
// rewrite to avoid pruning columns
if (context.getQueryMaterializationContext().hasRewrittenSuccess()) {
logicOperatorTree = new SeparateProjectRule().rewrite(logicOperatorTree, context.getTaskContext());
}
}

OptExpression result = optimizerOptions.isRuleBased() ?
Expand Down
43 changes: 1 addition & 42 deletions ...m/starrocks/sql/optimizer/rule/transformation/MaterializedViewTransparentRewriteRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import com.starrocks.sql.optimizer.OptimizerContext;
import com.starrocks.sql.optimizer.QueryMaterializationContext;
import com.starrocks.sql.optimizer.Utils;
import com.starrocks.sql.optimizer.base.ColumnRefSet;
import com.starrocks.sql.optimizer.operator.OperatorType;
import com.starrocks.sql.optimizer.operator.logical.LogicalOlapScanOperator;
import com.starrocks.sql.optimizer.operator.logical.LogicalScanOperator;
Expand All @@ -44,15 +43,12 @@
import com.starrocks.sql.optimizer.rule.transformation.materialization.MvPartitionCompensator;
import com.starrocks.sql.optimizer.rule.transformation.materialization.MvUtils;
import com.starrocks.sql.optimizer.rule.transformation.materialization.OptExpressionDuplicator;
import com.starrocks.sql.optimizer.rule.transformation.materialization.compensation.MVCompensation;
import com.starrocks.sql.optimizer.rule.transformation.materialization.compensation.MVCompensationBuilder;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;

Expand Down Expand Up @@ -177,7 +173,7 @@ private OptExpression doGetMvTransparentPlan(ConnectContext connectContext,
List<ColumnRefOperator> expectOutputColumns = mvColumns.stream()
.map(c -> columnToColumnRefMap.get(c))
.collect(Collectors.toList());
OptExpression result = getMvTransparentPlan(mvContext, input, expectOutputColumns);
OptExpression result = MvPartitionCompensator.getMvTransparentPlan(mvContext, input, expectOutputColumns);
if (result != null) {
logMVRewrite(mvContext, "Success to generate transparent plan");
return result;
Expand Down Expand Up @@ -227,43 +223,6 @@ private OptExpression redirectToMVDefinedQuery(OptimizerContext context,
return getMvDefinedQueryPlan(mvPlanContext.getLogicalPlan(), mvContext, expectOutputColumns);
}

/**
* Get transparent plan if possible.
* What's the transparent plan?
* see {@link MvPartitionCompensator#getMvTransparentPlan(MaterializationContext, MVCompensation, List, ColumnRefSet)}
*/
private OptExpression getMvTransparentPlan(MaterializationContext mvContext,
OptExpression input,
List<ColumnRefOperator> expectOutputColumns) {
// NOTE: MV's mvSelectPartitionIds is not trusted in transparent since it is targeted for the whole partitions(refresh
// and no refreshed).
// 1. Decide ref base table partition ids to refresh in optimizer.
// 2. consider partition prunes for the input olap scan operator
MvUpdateInfo mvUpdateInfo = mvContext.getMvUpdateInfo();
if (mvUpdateInfo == null || !mvUpdateInfo.isValidRewrite()) {
logMVRewrite(mvContext, "Failed to get mv to refresh partition info: {}", mvContext.getMv().getName());
return null;
}
MVCompensationBuilder mvCompensationBuilder = new MVCompensationBuilder(mvContext, mvUpdateInfo);
MVCompensation mvCompensation = mvCompensationBuilder.buildMvCompensation(Optional.empty());
if (mvCompensation == null) {
logMVRewrite(mvContext, "Failed to get mv compensation info: {}", mvContext.getMv().getName());
return null;
}
logMVRewrite(mvContext, "Get mv compensation info: {}", mvCompensation);
if (mvCompensation.isNoCompensate()) {
return input;
}
if (mvCompensation.isUncompensable()) {
logMVRewrite(mvContext, "Return directly because mv compensation info cannot compensate: {}",
mvCompensation);
return null;
}
OptExpression transparentPlan = MvPartitionCompensator.getMvTransparentPlan(mvContext, mvCompensation,
expectOutputColumns, false);
return transparentPlan;
}

/**
* If transparent plan is not available, get defined query plan and reset its selected partitions for further partition prune.
*/
Expand Down
Loading
Loading