Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Only trigger to inactive mv in leader fe #56308

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[BugFix] Only trigger to inactive mv in leader fe #56308

merged 1 commit into from
Feb 27, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Feb 26, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/9320

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@LiShuMing LiShuMing requested a review from a team as a code owner February 26, 2025 11:14
@LiShuMing LiShuMing mentioned this pull request Feb 26, 2025
Merged
24 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@LiShuMing LiShuMing enabled auto-merge (squash) February 26, 2025 11:49
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 2 / 3 (66.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/AlterMVJobExecutor.java 2 3 66.67% [569]

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions github-actions bot added 3.4 and removed 3.4 3.3 labels Feb 26, 2025
@kangkaisen kangkaisen disabled auto-merge February 27, 2025 01:44
@kangkaisen kangkaisen merged commit a0a496f into StarRocks:main Feb 27, 2025
95 of 104 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 27, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 27, 2025
@LiShuMing @mergify
[BugFix] Only trigger to inactive mv in leader fe (#56308)
5788cf4 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit a0a496f)
@mergify mergify bot mentioned this pull request Feb 27, 2025
Merged
18 tasks
andyziye pushed a commit that referenced this pull request Feb 27, 2025
@mergify @LiShuMing
[BugFix] Only trigger to inactive mv in leader fe (backport #56308) (#…
3f79ce4 
…56325)

Co-authored-by: shuming.li <[email protected]>
mergify bot added a commit that referenced this pull request Feb 27, 2025
@mergify
[BugFix] Only trigger to inactive mv in leader fe (backport #56308) (#…
9bd2721 
…56325)

Co-authored-by: shuming.li <[email protected]>
(cherry picked from commit 3f79ce4)
andyziye pushed a commit that referenced this pull request Feb 27, 2025
@mergify
[BugFix] Only trigger to inactive mv in leader fe (backport #56308) (…
425ca43 
…backport #56325) (#56335)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiShuMing @satanson @kangkaisen @HangyuanLiu