Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Wait apply finish out of tablet meta lock when set tablet state as SHUTDOWN (backport #56266) #56351

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2025

Why I'm doing:

In current impl, when set state as SHUTDOWN for primary key tablet, BE will wait until apply task has been finished inside the tablet meta lock leading many lock contention problem. But it is no need to hold the tablet meta lock when waiting the finishing of the background apply task.

What I'm doing:

Lock free for tablet meta lock to wait the apply task before setting the state as SHUTDOWN.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…et state as SHUTDOWN (#56266)

Signed-off-by: srlch <[email protected]>
(cherry picked from commit 76db0ef)
@wanpengfei-git wanpengfei-git merged commit 0185c04 into branch-3.2 Feb 27, 2025
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-56266 branch February 27, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants