Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Abstract a class named CacheEnv to uniformly manage the initialization of the cache #56375

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Feb 27, 2025

Why I'm doing:

Later, we will implement some functions related to cache compatibility, cache unification, and adjustment of memory allocation for different caches. To facilitate management, we will abstract a class named CacheEnv to uniformly manage the initialization of the cache.

What I'm doing:

Abstract a class named CacheEnv to uniformly manage the initialization of the cache.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
@trueeyu trueeyu changed the title [Refactor] Abstract a class named CacheEnv to uniformly manage all caches [Refactor] Abstract a class named CacheEnv to uniformly manage the initialization of the cache Feb 28, 2025
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
@trueeyu trueeyu marked this pull request as ready for review February 28, 2025 02:39
@trueeyu trueeyu requested review from a team as code owners February 28, 2025 02:39
Signed-off-by: trueeyu <[email protected]>
Copy link

[BE Incremental Coverage Report]

fail : 97 / 134 (72.39%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/service/service_be/http_service.cpp 0 3 00.00% [72, 73, 266]
🔵 src/service/service_be/starrocks_be.cpp 0 5 00.00% [108, 109, 123, 196, 197]
🔵 src/runtime/exec_env.h 5 17 29.41% [244, 248, 255, 258, 259, 260, 261, 262, 264, 265, 266, 268]
🔵 src/runtime/exec_env.cpp 88 105 83.81% [325, 332, 335, 382, 383, 384, 385, 404, 433, 450, 451, 495, 496, 499, 500, 501, 502]
🔵 src/storage/page_cache.cpp 4 4 100.00% []

Signed-off-by: trueeyu <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant