[BugFix] fix invalid expression usage (backport #56064) #56405
Merged
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression introduced in
#44588
expr_context(...)
create copy of
root_expr
asnew_expr
andnew ExprContext
pupulateExprContext._fn_contexts
and updateVectorizedFunctionCallExpr._fn_context_index
insidenew_expr
after return from function we do call of
get_predicate_value
withnew_expr_ctx
+root_expr
insideroot_expr
we can have incorrectVectorizedFunctionCallExpr._fn_context_index
, because indexes apply for another contextas result later we have errors
for our case
_fn_context_index = 3
and_fn_contexts.size() = 2
after fix we will use proper updated expressions with correct expression context
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: