Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Rust documentation - part 1 #106

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

boswelja
Copy link
Contributor

@boswelja boswelja commented Dec 23, 2024

This brings essentially all of lib.rs (including crate docs) to what I feel is a pretty good place. I'm sure there's room for improvement, and there's certainly more to document beyond there, but the main page should look pretty good now 😄

@akshayballal95
Copy link
Collaborator

Apologies for the late reply, but this looks good till now.

Cargo.toml Outdated Show resolved Hide resolved
@akshayballal95
Copy link
Collaborator

Hey, let me know once you are ready to convert this from draft to final.

@boswelja
Copy link
Contributor Author

Hey, let me know once you are ready to convert this from draft to final.

Sorry for the hold up, I've only been working on this on-and-off between work 😅

I think this branch is in a pretty good place for the public functions in lib.rs. I'd like to go over the other public functions in other files too, but happy to split that into a separate PR if you'd prefer

@akshayballal95
Copy link
Collaborator

akshayballal95 commented Jan 25, 2025

That's cool. I will check this out and try to merge the PR today. Thanks for the contribution. Rust docs are much needed.

@boswelja boswelja marked this pull request as ready for review January 25, 2025 11:56
@boswelja boswelja changed the title Rewrite Rust documentation Rewrite Rust documentation - part 1 Jan 25, 2025
@boswelja
Copy link
Contributor Author

What happened to the branch history 😬

@akshayballal95 akshayballal95 merged commit 2488f88 into StarlightSearch:main Jan 28, 2025
5 checks passed
@boswelja boswelja deleted the documentation branch January 28, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants