Add IntOrString custom type for VM IDs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this library was written, PVE 8.1.4 was the latest release. In that release, the API field for an LXC's "VMID" returned a string. Today the latest PVE version is 8.2.4, and this same field is now an integer. In the library it would be ideal to support both versions, so I wrote a custom type that parses down into a string regardless of the type from the API.
Also added some new tests to help with testing this functionality, and bring the overall test coverage up.
There were also several struct fields that were named with inconsistent casing, which were brought in line, which is maybe less than ideal for this PR to include those but here we are.