Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show CS Rating history on CS2 achievements page #192

Merged
merged 12 commits into from
Sep 9, 2024

Conversation

ge-ku
Copy link
Contributor

@ge-ku ge-ku commented Sep 8, 2024

Feel free to quickly reject this :)
There may be too much data in the future or Valve changes https://steamcommunity.com/my/gcpd/730?tab=majors page.

But it seems to work now and shouldn't break anything if it fails. It works only on your own page obviously.

image

@xPaw
Copy link
Member

xPaw commented Sep 8, 2024

Not that I dislike it, but seems a little weird to put this under achievements.

@ge-ku
Copy link
Contributor Author

ge-ku commented Sep 8, 2024

I don't know where else to put it. And rarely some older games (like l4d2) had a bunch of extra data including leaderboards so I thought it was fitting. Especially since CS2 has just one achievement.

@xPaw
Copy link
Member

xPaw commented Sep 8, 2024

Eh fine let's add it.

Suggestions:

  • rows don't need the height attribute
  • dont need centered text here
  • format the rating with a comma for thousands like in-game
  • need better colors for the rank changes (can also color it differently if its like >200 points of change or something)
  • add font-variant-numeric: tabular-nums;
  • put + in the text instead of css
  • move css to a separate file
  • the repeated 'season 1' text feels unnecessary, could group it into headings

What are the other bits of information we could extract from the score variable?

Wondering if we should draw a chart of the rating for like last 100 matches, code from steamstat.us here: https://github.com/SteamDatabase/steamstat.us/blob/3e0fecc70c9d806cba260f78f73bd2795cb7365c/src/app.ts#L208

@ge-ku
Copy link
Contributor Author

ge-ku commented Sep 9, 2024

Made changes based on your suggestions. Tried adding a chart by mostly copy-pasting steamstat.us code, I think it works alright.

image

What are the other bits of information we could extract from the score variable?

Not sure, I thought they just store it in some fixed-point decimal format. But maybe those bits do represent something useful?

@xPaw
Copy link
Member

xPaw commented Sep 9, 2024

I've added colors and a slider to the graph:

image

@xPaw xPaw merged commit 1768999 into SteamDatabase:master Sep 9, 2024
1 check passed
@ge-ku
Copy link
Contributor Author

ge-ku commented Sep 9, 2024

Looks very cool with colors 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants