Fix code scanning alert no. 20: Unsafe jQuery plugin #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
We can update our own imported modules 1/year or so, but try not to diverge from upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Stellarium/stellarium/security/code-scanning/20
To fix the problem, we need to ensure that the
options.ofinput is always treated as a CSS selector and not as HTML. This can be achieved by using thejQuery.findmethod, which interprets the input strictly as a CSS selector. This change will prevent any potential XSS vulnerabilities arising from interpreting the input as HTML.Suggested fixes powered by Copilot Autofix. Review carefully before merging.