feat: parse schema from SDL #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
force-pushed
the
add-sdl-parsing
branch
4 times, most recently
from
fb7ff6c to
d3ae0fc
Compare
JoviDeCroock
force-pushed
the
add-sdl-parsing
branch
from
d3ae0fc to
6f50164
Compare
…whether this is a bug as a possible interface is also a possible type
dpetrick
approved these changes
May 28, 2024
| @@ -154,7 +154,7 @@ pub enum IntrospectionInputTypeRef<'a> { | |||
| #[cfg_attr(feature = "json", derive(Deserialize, Serialize))] | |||
| #[cfg_attr(feature = "json", serde(rename_all = "camelCase"))] | |||
| pub struct IntrospectionNamedTypeRef<'a> { | |||
| #[cfg_attr(feature = "json", serde(skip))] | |||
| #[cfg_attr(feature = "json", serde(borrow))] | |||
There was a problem hiding this comment.
Did you end up figuring out what's up here with the skips?
| schema_interface.add_possible_type(ctx, obj); | ||
| } | ||
|
|
||
| // TODO: possible interfaces aren't conveyed in the introspection |
There was a problem hiding this comment.
Should there be post-processing to determine those? I' not sure what other SDL parsers do.
There was a problem hiding this comment.
Possible interfaces actually doesn't exist in the reference implementation, not sure why we added that
Co-authored-by: Dominic Petrick <[email protected]>
Co-authored-by: Dominic Petrick <[email protected]>
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the Schema Definition Language, currently this supports a schema like the following
It misses two SDL functionalities
This includes an initial set of validations that still need testing