Hardening suggestions for Stirling-PDF / multipleFix #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| @@ -77,7 +77,7 @@ public static boolean isValidURL(String urlStr) { | |||
|
|
|||
| public static boolean isURLReachable(String urlStr) { | |||
| try { | |||
| URL url = new URL(urlStr); | |||
There was a problem hiding this comment.
Wrapped the URL creation with a method that forces the caller to pick allowed protocols and domains that this URL can reach
There was a problem hiding this comment.
@pixeebot for things like this i would love to see a link to what domains it allows and doesn't, I have no idea if I can allow this PR based on this general description
There was a problem hiding this comment.
Great idea! We just made this change: pixee/codemodder-java#442.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (1742 - Multiple flag fix) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs