Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added warning to c++ solvers when variables are specified for non-var… #956

Merged
merged 1 commit into from
Aug 1, 2024
Merged

added warning to c++ solvers when variables are specified for non-var… #956

merged 1 commit into from
Aug 1, 2024

Conversation

benblamey
Copy link
Contributor

…iable solvers. fixes #955.

@jtcooper10 jtcooper10 changed the base branch from main to develop July 25, 2024 15:39
@briandrawert briandrawert deleted the branch StochSS:develop July 25, 2024 15:39
@briandrawert briandrawert reopened this Jul 25, 2024
@briandrawert briandrawert mentioned this pull request Jul 25, 2024
Open
@briandrawert
Copy link
Member

Code review: needs unit tests.
https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertLogs

@benblamey benblamey force-pushed the cpp_variables_issue branch 3 times, most recently from 209bdae to cda2b1f Compare July 25, 2024 21:35
@benblamey benblamey force-pushed the cpp_variables_issue branch from cda2b1f to 2320590 Compare July 26, 2024 08:24
@briandrawert briandrawert merged commit b6335a4 into StochSS:develop Aug 1, 2024
1 check failed
@benblamey benblamey deleted the cpp_variables_issue branch August 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

variables are silently ignored by non-variable C++ solvers
2 participants
@benblamey @briandrawert