Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changing base URI when $ref is present in drafts 7 and earlier #505

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Stranger6667
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (ce678a1) to head (83ed025).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   89.98%   90.02%   +0.03%     
==========================================
  Files          58       58              
  Lines       10057    10096      +39     
==========================================
+ Hits         9050     9089      +39     
  Misses       1007     1007              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #505 will degrade performances by 19.4%

Comparing dd/fix-sibling-id (83ed025) with master (ce678a1)

Summary

⚡ 1 improvements
❌ 39 regressions
✅ 280 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dd/fix-sibling-id Change
additional_items_boolean 1234[jsonschema/is_valid/invalid] 331.4 ns 389.7 ns -14.97%
additional_properties_and_properties foo1[jsonschema/is_valid/valid] 1.2 µs 1.3 µs -11.1%
any_of 1.5[jsonschema/is_valid/invalid] 993.3 ns 1,110 ns -10.51%
any_of_multiple_types foo[jsonschema/is_valid/valid] 766.1 ns 853.6 ns -10.25%
any_of_multiple_types null[jsonschema/is_valid/invalid] 766.9 ns 854.4 ns -10.24%
contains 1[jsonschema/is_valid/invalid] 643.1 ns 730.6 ns -11.98%
contains 5[jsonschema/is_valid/valid] 613.1 ns 700.6 ns -12.49%
enum 4[jsonschema/is_valid/valid] 702.8 ns 819.4 ns -14.24%
enum 5[jsonschema/is_valid/invalid] 732.5 ns 820 ns -10.67%
enum 6[jsonschema/is_valid/invalid] 334.7 ns 393.1 ns -14.84%
format_hostname not_a_valid_host_name[jsonschema/is_valid/invalid] 732.8 ns 820.3 ns -10.67%
format_ipv6 127.0.0.1[jsonschema/is_valid/invalid] 724.4 ns 811.9 ns -10.78%
format_iri_reference #ƒräg\\mênt[jsonschema/validate/invalid] 7.4 µs 8.4 µs -11.98%
format_time 083006.283185Z[jsonschema/validate/valid] 5.9 µs 5 µs +18.93%
items 123[jsonschema/is_valid/valid] 656.4 ns 743.9 ns -11.76%
items 12x[jsonschema/is_valid/invalid] 654.7 ns 742.2 ns -11.79%
max_items 12[jsonschema/is_valid/invalid] 300 ns 358.3 ns -16.28%
max_items 1[jsonschema/is_valid/valid] 300 ns 358.3 ns -16.28%
max_length aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[jsonschema/is_valid/invalid] 702.2 ns 818.9 ns -14.25%
max_length foo[jsonschema/is_valid/valid] 548.9 ns 636.4 ns -13.75%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Stranger6667 Stranger6667 merged commit 8cb04dd into master Sep 11, 2024
32 of 33 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-sibling-id branch September 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant