feat: Add saverestore API #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koerismo
added
awaiting implementation
koerismo
requested changes
Aug 21, 2024
| /** | ||
| * Defines the save type, used with 'GameSaved' event in the 'type' parameter | ||
| */ | ||
| declare enum SaveType { |
There was a problem hiding this comment.
We want to use declare const enum, unless SaveType is defined in the global scope.
| @@ -88,4 +88,5 @@ interface GlobalEventNameMap { | |||
| 'UnloadLoadingScreenAndReinit': () => void, | |||
| 'AchievementInfoLoaded': () => void, | |||
| 'AchievementEarned': (player_index: number, achievement_index: number) => void, | |||
| 'GameSaved': (save_name: string, save_type: number) => void, | |||
There was a problem hiding this comment.
You can use save_type: SaveType instead of save_type: number here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2CE save-restore API. Not merged into the engine yet.