add filename video param
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBeastLT
reviewed
Dec 1, 2023
TheBeastLT
reviewed
Dec 1, 2023
| @@ -860,7 +862,8 @@ fn subtitles_update<E: Env + 'static>( | |||
| .extend_one( | |||
| &VIDEO_SIZE_EXTRA_PROP, | |||
| video_params.size.as_ref().map(|size| size.to_string()), | |||
| ), | |||
| ) | |||
| .extend_one(&VIDEO_FILENAME_EXTRA_PROP, video_params.filename.to_owned()), | |||
There was a problem hiding this comment.
Since this is going to be part of Stream.behaviourHints object, maybe we should take from there?
There was a problem hiding this comment.
that logic is in stremio-video
There was a problem hiding this comment.
Tho that means that every client will have to duplicate this logic, extracting values from Stream.behaviourHints and passing them via VideoParams instead of core taking care of that.
There was a problem hiding this comment.
yes, every non js app :(
we can think of way to move that logic to rust
TheBeastLT
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.