Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement events for ctx #585

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feat: implement events for ctx #585

merged 5 commits into from
Dec 12, 2023

Conversation

tymmesyde
Copy link
Member

For modals and notifications

@tymmesyde tymmesyde mentioned this pull request Dec 11, 2023
Merged
elpiel
elpiel reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

src/runtime/msg/action.rs Show resolved Hide resolved
src/runtime/msg/internal.rs Outdated Show resolved Hide resolved
src/types/api/response.rs Outdated Show resolved Hide resolved
src/types/api/response.rs Outdated Show resolved Hide resolved
src/types/api/response.rs Outdated Show resolved Hide resolved
@tymmesyde tymmesyde merged commit 15e540e into development Dec 12, 2023
1 check passed
@elpiel elpiel deleted the feat/implement-ctx-events branch December 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tymmesyde @elpiel