feat: implement dismissed events bucket #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
reviewed
Dec 14, 2023
elpiel
reviewed
Dec 14, 2023
Co-authored-by: Lachezar Lechev <[email protected]>
Co-authored-by: Lachezar Lechev <[email protected]>
elpiel
reviewed
Dec 14, 2023
src/models/ctx/update_events.rs
Outdated
Comment on lines
83
to
95
| Some(GetNotificationResponse { id, .. }) | ||
| if !dismissed_events.items.contains_key(id) => | ||
| { | ||
| eq_update( | ||
| &mut events.notification, | ||
| Loadable::Ready(response.to_owned()), | ||
| ) | ||
| } | ||
| _ => eq_update( | ||
| &mut events.notification, | ||
| Loadable::Ready(response.to_owned()), | ||
| ), | ||
| }, |
There was a problem hiding this comment.
- case that is not handled: Event that's dismissed should not result to
Loadable::Ready
There was a problem hiding this comment.
The request was successful so it's Ready, not loading, not an error
If it was dismissed, it returns None
elpiel
reviewed
Dec 14, 2023
src/models/ctx/update_events.rs
Outdated
| Some(GetModalResponse { id, .. }) if !dismissed_events.items.contains_key(id) => { | ||
| eq_update(&mut events.modal, Loadable::Ready(response.to_owned())) | ||
| } | ||
| _ => eq_update(&mut events.modal, Loadable::Ready(response.to_owned())), |
There was a problem hiding this comment.
Same for this match. Both match arms are equal and we need to handle the case where we have dismissed the Modal
- fix match
There was a problem hiding this comment.
Check the test, if the modal was dismissed, events.modal will be Loadable:Ready(None)
There was a problem hiding this comment.
I can put explicitly Loadable::Ready(None) if you prefer
There was a problem hiding this comment.
No you are absolutely right, will fix that
elpiel
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.