Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Option for audio_language and subtitles_language #626

Merged

Conversation

tymmesyde
Copy link
Member

@tymmesyde tymmesyde commented Jan 22, 2024

Allow to set to null/to disable audio and subtitles language

@tymmesyde tymmesyde requested a review from elpiel January 29, 2024 13:46
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we always set some defaults on purpose?
Looks good to me otherwise.

@tymmesyde tymmesyde merged commit 9ba36f6 into development Feb 2, 2024
2 checks passed
@elpiel elpiel deleted the refactor/settings-option-subtitles-audio-lang branch April 3, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants