Dev progress #2
Merged
Dev progress #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
approved these changes
Jul 13, 2021
| } | ||
| Ok(()) | ||
| } | ||
| fn process_event<'a>( |
There was a problem hiding this comment.
such a handler is a good idea for sure
| pub struct WebView { | ||
| controller: Rc<OnceCell<Controller>>, | ||
| } | ||
| impl PartialUi for WebView { |
There was a problem hiding this comment.
That's interesting, didn't know NWG has PartialUi.
elpiel
reviewed
Nov 4, 2022
|
|
||
| #[derive(Serialize, Deserialize, Debug, Clone)] | ||
| pub struct RPCRequest { | ||
| pub id: u64, |
There was a problem hiding this comment.
Please check if we're building the code for 32bits if we have to change this to u32 or the compiler is able to do some magic and compile u64 on 32bit builds.
src/stremio_app/named_pipe.rs
Outdated
Comment on lines
4
to
7
| use kernel32::{ | ||
| CloseHandle, ConnectNamedPipe, CreateFileW, CreateNamedPipeW, DisconnectNamedPipe, | ||
| FlushFileBuffers, ReadFile, WaitNamedPipeW, WriteFile, | ||
| }; |
There was a problem hiding this comment.
Out of curiosity: Why do we use this kernel32 from windows?
Isn't it possible to use the std::fs module for e.g. Reading a file?
Comment on lines
+222
to
+231
| trait MpvExt { | ||
| fn wake_up(&self); | ||
| } | ||
|
|
||
| impl MpvExt for Mpv { | ||
| // @TODO create a PR to the `libmpv` crate and then remove `libmpv-sys` from Cargo.toml? | ||
| fn wake_up(&self) { | ||
| unsafe { libmpv_sys::mpv_wakeup(self.ctx.as_ptr()) } | ||
| } | ||
| } |
There was a problem hiding this comment.
yes, I guess you can either export this unsafe function or add a function to Mpv that wraps it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is nowhere finished. It is just for tracking the progress.